I get the sense there’s not a thing in the universe I could say that might encourage you to try out another person’s perspective, even if only for a moment or two.

So thank you for your time. You have gone to pains to remind us that you have spent your free time reviewing plugins for free — and even invited me to hire you if I want any substantive input on actual code. So, I am guessing it would be a poor investment of my own time to put further effort into highlighting what seems to me like an important distinction between reviewing indentation and reviewing code.

Thanks again,
Greg

It’s not like I’m a crazy person who gives overrated importance to *basic* code formatting. It’s just the way everybody should do it. Yes, obviously, if it’s unreadable, I don’t read it. No, I’m not going to spend an extra 20 mn on top of every hours or so that a single review requires to reformat your crappy stuff. Maybe once it’s readable it’ll be neat, maybe not. And no, I don’t “conflate code and code formatting”. But if food *smells* like shit, I don’t *taste* it. Same thing for code.

Thank you for thanking me for spending my free time reviewing for free your plugin. Now if you want more feedback on your code, feel free to HIRE somebody (or me, even).

Does it make your job easier to be able to mark a plugin off your list as ‘done’ because you don’t like the way the source code is indented?

I’m sure you know the difference between code and code formatting, but over and over and over again in your ‘reviews’ above, you conflate the two terms — giving us your gut reaction to code formatting as if it were a critical evaluation (or even a vaguely well-informed evaluation) of actual code.

Of course I’m biased, because it seems you were unable to get past my own apparently heinous code formatting choices while dumping all over my actual code. Since I had hoped for substantive feedback on my plugin, I’m pretty disappointed that the code didn’t even get a serious look because its formatting wasn’t good enough for you. I really would have valued feedback on something other than formatting.

I get it: you like pretty indentation. But most programmers do know how to tweak source code display to suit their own preferences — rather than expecting everyone else to divine and agree with (or at least comply with) their own personal requirements.

http://lmgtfy.com/?q=php+source+code+prettifier

I’m going to stick with writing code for users, formatting my code so it suits how I like to view it, and asking for feedback from folks who are more interested in grasping code than critiquing code formatting.

Oh well,
Greg

We’ll be moving the site over to SEO Ultimate once I create an importer to move over years’ worth of post metadata from All in One SEO Pack.

- John
SEO Ultimate developer

Thanks for the time and the reviews. It’s always good to get constructive criticism and that too from someone with authority. I am modifying my Plugins to fix the things that you have reported.

I have a small request. It would be helpful if you could add named anchors for each Plugin, so that we could link to that particular part of the document using #pluginname.